Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Michael S. Tsirkin
On Tue, Jan 15, 2019 at 02:38:22PM +0100, Cornelia Huck wrote: > On Tue, 15 Jan 2019 16:11:19 +0300 > Dima Stepanov wrote: > > > On Tue, Jan 15, 2019 at 11:40:09AM +0100, Cornelia Huck wrote: > > > On Tue, 15 Jan 2019 13:08:47 +0300 > > > Dima Stepanov wrote: > > > > > > > The virtqueue_pop()

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Stefan Hajnoczi
On Tue, Jan 15, 2019 at 01:08:47PM +0300, Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > addres

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2019 16:11:19 +0300 Dima Stepanov wrote: > On Tue, Jan 15, 2019 at 11:40:09AM +0100, Cornelia Huck wrote: > > On Tue, 15 Jan 2019 13:08:47 +0300 > > Dima Stepanov wrote: > > > > > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > > > INDIRECT table to g

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Dima Stepanov
On Tue, Jan 15, 2019 at 11:40:09AM +0100, Cornelia Huck wrote: > On Tue, 15 Jan 2019 13:08:47 +0300 > Dima Stepanov wrote: > > > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > > INDIRECT table to get the data. It is possible to create a packet which > > will lead to th

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2019 13:08:47 +0300 Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > address_spa

Re: [Qemu-devel] [PATCH v1] virtio: add checks for the size of the indirect table

2019-01-15 Thread Philippe Mathieu-Daudé
On 1/15/19 11:08 AM, Dima Stepanov wrote: > The virtqueue_pop() and virtqueue_get_avail_bytes() routines can use the > INDIRECT table to get the data. It is possible to create a packet which > will lead to the assert message like: > include/exec/memory.h:1995: void > address_space_read_cached(M