Re: [Qemu-devel] [PATCH target-arm v2] display: avoid multi-statement macro

2014-01-27 Thread Peter Maydell
On 24 January 2014 19:08, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while(0)", or just

Re: [Qemu-devel] [PATCH target-arm v2] display: avoid multi-statement macro

2014-01-27 Thread Laszlo Ersek
On 01/24/14 20:08, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while(0)", or just remove t