Re: [Qemu-devel] [PATCH qemu 3/6] virtio-input: core code & base class

2014-04-11 Thread Gerd Hoffmann
Hi, > > It's not different from other input devices. No buffer space -> drop > > event. What else do you think should happen? We could signal "you lost > > events" to the guest, but I suspect that buys us nothing. Other input > > devices don't have that capability, so guests are likely not p

Re: [Qemu-devel] [PATCH qemu 3/6] virtio-input: core code & base class

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 02:22:17PM +0200, Gerd Hoffmann wrote: > On Do, 2014-04-10 at 14:06 +0300, Michael S. Tsirkin wrote: > > > +void virtio_input_send(VirtIOInput *vinput, virtio_input_event > > *event) > > > +{ > > > +VirtQueueElement elem; > > > +int len; > > > + > > > +if (!virtq

Re: [Qemu-devel] [PATCH qemu 3/6] virtio-input: core code & base class

2014-04-10 Thread Gerd Hoffmann
On Do, 2014-04-10 at 14:06 +0300, Michael S. Tsirkin wrote: > > +void virtio_input_send(VirtIOInput *vinput, virtio_input_event > *event) > > +{ > > +VirtQueueElement elem; > > +int len; > > + > > +if (!virtqueue_pop(vinput->evt, &elem)) { > > +fprintf(stderr, "%s: virtqueue emp

Re: [Qemu-devel] [PATCH qemu 3/6] virtio-input: core code & base class

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 11:07:51AM +0200, Gerd Hoffmann wrote: > This patch adds virtio-input support to qemu. It brings a abstract > base class providing core support, other classes can build on it to > actually implement input devices. > > virtio-input basically sends linux input layer events (