Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-13 Thread Laurent Vivier
Le 12/08/2015 07:12, Richard Henderson a écrit : > On 08/09/2015 01:13 PM, Laurent Vivier wrote: >> @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env, > >> @@ -1706,16 +1745,18 @@ DISAS_INSN(branch) >> /* bsr */ >> gen_push(s, tcg_const_i32(s->pc)); >> }

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 23:19, Richard Henderson a écrit : > On 08/12/2015 01:56 PM, Laurent Vivier wrote: -DEF_HELPER_2(flush_flags, void, env, i32) +DEF_HELPER_2(flush_flags, i32, env, i32) >>> >>> Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it >>> reads some globals, but

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Richard Henderson
On 08/12/2015 01:56 PM, Laurent Vivier wrote: -DEF_HELPER_2(flush_flags, void, env, i32) +DEF_HELPER_2(flush_flags, i32, env, i32) Modify to use DEF_HELPER_FLAGS while you're at it. At the moment it reads some globals, but doesn't write any, or have any other side effects. It writes "env->cc

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 07:12, Richard Henderson a écrit : > On 08/09/2015 01:13 PM, Laurent Vivier wrote: >> @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env, >> uint32_t acc) >> } >> } >> >> -void HELPER(flush_flags)(CPUM68KState *env, uint32_t cc_op) >> +uint32_t HELPER(flush_fla

Re: [Qemu-devel] [PATCH for-2.5 08/30] m68k: update CPU flags management

2015-08-11 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: @@ -798,9 +796,9 @@ void HELPER(mac_set_flags)(CPUM68KState *env, uint32_t acc) } } -void HELPER(flush_flags)(CPUM68KState *env, uint32_t cc_op) +uint32_t HELPER(flush_flags)(CPUM68KState *env, uint32_t op) { -cpu_m68k_flush_flags(env,