Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-20 Thread Amit Shah
On (Thu) 20 Nov 2014 [09:16:31], Igor Mammedov wrote: > On Thu, 20 Nov 2014 09:49:20 +0530 > Amit Shah wrote: > > > On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote: > > > On Wed, 19 Nov 2014 12:51:00 +0530 > > > Amit Shah wrote: > > > > > > > -static void *acpi_add_rom_blob(AcpiBuildState

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-20 Thread Igor Mammedov
On Thu, 20 Nov 2014 09:49:20 +0530 Amit Shah wrote: > On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote: > > On Wed, 19 Nov 2014 12:51:00 +0530 > > Amit Shah wrote: > > > > > -static void *acpi_add_rom_blob(AcpiBuildState *build_state, GArray > > > > *blob, +static ram_addr_t acpi_add_rom_bl

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-19 Thread Amit Shah
On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote: > On Wed, 19 Nov 2014 12:51:00 +0530 > Amit Shah wrote: > > > -static void *acpi_add_rom_blob(AcpiBuildState *build_state, GArray > > > *blob, +static ram_addr_t acpi_add_rom_blob(AcpiBuildState > > > *build_state, GArray *blob, const char *na

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 12:51:00PM +0530, Amit Shah wrote: > On (Mon) 17 Nov 2014 [19:04:13], Michael S. Tsirkin wrote: > > acpi build modifies internal FW CFG RAM on first access > > but we forgot to mark it dirty. > > If this RAM has been migrated already, it won't be > > migrated again, returnin

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-19 Thread Igor Mammedov
On Wed, 19 Nov 2014 12:51:00 +0530 Amit Shah wrote: > On (Mon) 17 Nov 2014 [19:04:13], Michael S. Tsirkin wrote: > > acpi build modifies internal FW CFG RAM on first access > > but we forgot to mark it dirty. > > If this RAM has been migrated already, it won't be > > migrated again, returning cor

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [19:04:13], Michael S. Tsirkin wrote: > acpi build modifies internal FW CFG RAM on first access > but we forgot to mark it dirty. > If this RAM has been migrated already, it won't be > migrated again, returning corrupted tables to guest. > > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-17 Thread Paolo Bonzini
On 17/11/2014 18:04, Michael S. Tsirkin wrote: > acpi build modifies internal FW CFG RAM on first access > but we forgot to mark it dirty. > If this RAM has been migrated already, it won't be > migrated again, returning corrupted tables to guest. > > Signed-off-by: Michael S. Tsirkin > --- > i