Re: [Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Martin Schrodt
On 3/14/19 10:34 PM, Philippe Mathieu-Daudé wrote: >> +static int qpa_validate_per_direction_opts (Audiodev *dev, >> AudiodevPaPerDirectionOptions *pdo) > > If this function is expected to return a boolean value, please use the > 'bool' C type and true/false. > >> +{ >> +if (!pdo->has_buffer

Re: [Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

2019-03-14 Thread Philippe Mathieu-Daudé
Hi Martin, On 3/14/19 3:26 PM, Martin Schrodt wrote: > Audiodev configuration allows to set the length of the buffered data. The > setting was ignored and a constant value used instead. This patch makes the > code apply the setting properly. > > Signed-off-by: Martin Schrodt > --- > audio/paa