Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-23 Thread Cornelia Huck
On Thu, 22 Feb 2018 14:29:09 -0500 Matthew Rosato wrote: > On 02/22/2018 06:13 AM, Christian Borntraeger wrote: > > > > > > On 02/21/2018 06:39 PM, Cornelia Huck wrote: > >> On Tue, 20 Feb 2018 16:05:54 +0100 > >> David Hildenbrand wrote: > >> > >>> On 20.02.2018 15:57, Cornelia Huck wrote

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-22 Thread Matthew Rosato
On 02/22/2018 06:13 AM, Christian Borntraeger wrote: > > > On 02/21/2018 06:39 PM, Cornelia Huck wrote: >> On Tue, 20 Feb 2018 16:05:54 +0100 >> David Hildenbrand wrote: >> >>> On 20.02.2018 15:57, Cornelia Huck wrote: On Tue, 20 Feb 2018 13:16:37 +0100 David Hildenbrand wrote:

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-22 Thread Christian Borntraeger
On 02/21/2018 06:39 PM, Cornelia Huck wrote: > On Tue, 20 Feb 2018 16:05:54 +0100 > David Hildenbrand wrote: > >> On 20.02.2018 15:57, Cornelia Huck wrote: >>> On Tue, 20 Feb 2018 13:16:37 +0100 >>> David Hildenbrand wrote: >>> On 20.02.2018 13:05, Christian Borntraeger wrote: >

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-21 Thread Cornelia Huck
On Tue, 20 Feb 2018 16:05:54 +0100 David Hildenbrand wrote: > On 20.02.2018 15:57, Cornelia Huck wrote: > > On Tue, 20 Feb 2018 13:16:37 +0100 > > David Hildenbrand wrote: > > > >> On 20.02.2018 13:05, Christian Borntraeger wrote: > >>> > >>> > >>> On 02/19/2018 06:42 PM, David Hildenbrand

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 15:57, Cornelia Huck wrote: > On Tue, 20 Feb 2018 13:16:37 +0100 > David Hildenbrand wrote: > >> On 20.02.2018 13:05, Christian Borntraeger wrote: >>> >>> >>> On 02/19/2018 06:42 PM, David Hildenbrand wrote: From an architecture point of view, nothing can be mapped into the a

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Cornelia Huck
On Tue, 20 Feb 2018 13:16:37 +0100 David Hildenbrand wrote: > On 20.02.2018 13:05, Christian Borntraeger wrote: > > > > > > On 02/19/2018 06:42 PM, David Hildenbrand wrote: > >> From an architecture point of view, nothing can be mapped into the address > >> space on s390x. All there is is mem

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 13:05, Christian Borntraeger wrote: > > > On 02/19/2018 06:42 PM, David Hildenbrand wrote: >> From an architecture point of view, nothing can be mapped into the address >> space on s390x. All there is is memory. Therefore there is also not really >> an interface to communicate such

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/19/2018 06:42 PM, David Hildenbrand wrote: > From an architecture point of view, nothing can be mapped into the address > space on s390x. All there is is memory. Therefore there is also not really > an interface to communicate such information to the guest. All we can do is > specify the ma

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread David Hildenbrand
On 20.02.2018 12:18, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different interface

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
On 02/20/2018 12:18 PM, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the idea. > We should have never folded this into the common code memory hotplug > infrastructure as it is different. Instead we really should have provided > a different inte

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-20 Thread Christian Borntraeger
Given that we have trouble modeling this properly I somewhat like the idea. We should have never folded this into the common code memory hotplug infrastructure as it is different. Instead we really should have provided a different interface and we should have build it with migration support. If