Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 14:21, Stefan Hajnoczi wrote: >> +guest = QEMUMachine(binary=os.environ.get("QEMU", >> "qemu-system-x86_64"), >> +args=args) >> +guest._vga = "std" > _vga is a protected field. We don't inherit from QEMUMachine so it > shouldn't be accesse

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 10:47:40AM +0800, Fam Zheng wrote: > +self._args = [ \ > +"-nodefaults", "-enable-kvm", "-m", "2G", > +"-smp", os.environ.get("J", "4"), "-cpu", "host", I suggested making -j a command-line argument and constructor argument instead of using a

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Fam Zheng
> +self._args = [ \ > +"-nodefaults", "-enable-kvm", "-m", "2G", > +"-smp", os.environ.get("J", "4"), "-cpu", "host", Forgot to change "J" to a command argument. Will fix when dropping RFC. Fam