Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-14 Thread Peter Maydell
On 14 May 2013 09:06, Michael S. Tsirkin wrote: > On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: >> Bunch of coding style violations in this patch which will >> need fixing at some point in the RFC->patch process. > I went over it again and found one: > One is not a bunch so I ob

Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-14 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: > On 13 May 2013 21:01, Michael S. Tsirkin wrote: > > This fills in guest info table with misc > > information of interest to the guest. > > Will be used by ACPI table generation code. > > Bunch of coding style violations in this patc

Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:01, Michael S. Tsirkin wrote: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. Bunch of coding style violations in this patch which will need fixing at some point in the RFC->patch process. thanks -