Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 10:38 +0530, Nikunj A Dadhania wrote: > One more question, when in gen_check_tlb_flush, don't I need to see > if other CPU has global flag set ? No, you leave it completely alone. You can clear it's local flag as part of the flush (in the MT-TCG case that can be done by the

Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Fri, 2016-09-09 at 10:15 +0530, Nikunj A Dadhania wrote: >> > Benjamin Herrenschmidt writes: >> >> > >> > On Fri, 2016-09-09 at 09:53 +0530, Nikunj A Dadhania wrote: >> > > >> > > tlbie (and H_REMOVE for pseries) should have a global effect. This is >> > >

Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 15:00 +1000, Benjamin Herrenschmidt wrote: > > No it doesn't. > > When a "broadcast TLB" op happens, such as tlbie, you set both flags. > The existing one which just means the current CPU needs flushing, that > logic doesnt' change at all. > > The other one means that *this

Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 10:15 +0530, Nikunj A Dadhania wrote: > > Benjamin Herrenschmidt writes: > > > > > On Fri, 2016-09-09 at 09:53 +0530, Nikunj A Dadhania wrote: > > > > > > tlbie (and H_REMOVE for pseries) should have a global effect. This is > > > achieved by iterating and setting tlb_need

Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Fri, 2016-09-09 at 09:53 +0530, Nikunj A Dadhania wrote: >> tlbie (and H_REMOVE for pseries) should have a global effect. This is >> achieved by iterating and setting tlb_need_flush in all the CPUs. >> >> Suggested-by: Benjamin Herrenschmidt >> Signed-off-by:

Re: [Qemu-devel] [PATCH RFC] target-ppc: tlbie should have global effect

2016-09-08 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 09:53 +0530, Nikunj A Dadhania wrote: > tlbie (and H_REMOVE for pseries) should have a global effect. This is > achieved by iterating and setting tlb_need_flush in all the CPUs. > > Suggested-by: Benjamin Herrenschmidt > Signed-off-by: Nikunj A Dadhania > > -- > > Note: H