Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Peter Crosthwaite
On Thu, Jul 31, 2014 at 10:05 PM, Paolo Bonzini wrote: > Il 31/07/2014 14:00, Peter Crosthwaite ha scritto: >> On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: >>> It is never used, since ISA device are not hot-unpluggable. >>> >> >> Is it not good design practice though for the uninit to be

Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:00, Peter Crosthwaite ha scritto: > On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: >> It is never used, since ISA device are not hot-unpluggable. >> > > Is it not good design practice though for the uninit to be correctly > implemented regardless of whether there is curren

Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Peter Crosthwaite
On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: > It is never used, since ISA device are not hot-unpluggable. > Is it not good design practice though for the uninit to be correctly implemented regardless of whether there is current-day usage? This seems like the kind of patch that would get