Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-12 Thread Paolo Bonzini
On 11/07/2018 19:52, Emanuele wrote: >>> >> Do you intend to delete this comment before this series is merged?  It >> seems like a TODO that doesn't need to be kept around. > Paolo suggested me to put it there, because there still are some devices > that need to be implemented. >> >>> +    qos_add_

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Emanuele
On 07/11/2018 05:15 PM, Stefan Hajnoczi wrote: On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: +/** + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. Paolo suggest

Re: [Qemu-devel] [PATCH 7/7] tests/qgraph: sdhci test node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:36AM +0200, Emanuele Giuseppe Esposito wrote: > +/** > + * Old sdhci_t structure: Do you intend to delete this comment before this series is merged? It seems like a TODO that doesn't need to be kept around. > +qos_add_test("sdhci-test", "sdhci", test_machine);