Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_str

2016-03-08 Thread Peter Xu
On Tue, Mar 08, 2016 at 09:10:44AM +0100, Gerd Hoffmann wrote: > > static void usb_mtp_add_str(MTPData *data, const char *str) > > { > > +#define __WSTR_LEN (256) > > uint32_t len = strlen(str)+1; > > -wchar_t wstr[len]; > > +wchar_t wstr[__WSTR_LEN]; > > I think we should g_malloc(

Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_str

2016-03-08 Thread Gerd Hoffmann
> static void usb_mtp_add_str(MTPData *data, const char *str) > { > +#define __WSTR_LEN (256) > uint32_t len = strlen(str)+1; > -wchar_t wstr[len]; > +wchar_t wstr[__WSTR_LEN]; I think we should g_malloc() here. cheers, Gerd