Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-16 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 08:15:59AM -0600, Eric Blake wrote: > On 09/15/2015 08:06 PM, Yuanhan Liu wrote: > > >> Up to here is mostly fine for the commit message. Meanwhile... > >> > >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handlers() > >>> once only, and invoke qemu_f

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-16 Thread Eric Blake
On 09/15/2015 08:06 PM, Yuanhan Liu wrote: >> Up to here is mostly fine for the commit message. Meanwhile... >> >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handlers() >>> once only, and invoke qemu_find_net_clients_except() at the handler >>> to gather all related nc

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-16 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 11:10:35AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > > If not, I'd like to put them into the commit log, as putting it > > outside the commit log gives unnecessary extra burden to patch > > author when he need update se

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-16 Thread Michael S. Tsirkin
On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > If not, I'd like to put them into the commit log, as putting it > outside the commit log gives unnecessary extra burden to patch > author when he need update several version change information > in a patch set: he has to format the patc

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > > From: Changchun Ouyang > > > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > > > Here is the

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple queue support, > > by creatin

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Eric Blake
On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > From: Changchun Ouyang > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. The phrase "Here is the latest

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-14 Thread Yuanhan Liu
On Mon, Sep 14, 2015 at 06:00:41PM +0800, Jason Wang wrote: > > > On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > > From: Ouyang Changchun > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple queue support, > > by cre

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-14 Thread Jason Wang
On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > From: Ouyang Changchun > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. > > What differs from last versi

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:38:46PM +0800, Yuanhan Liu wrote: > From: Ouyang Changchun > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. > > What diff

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Yuanhan Liu
On Wed, Sep 09, 2015 at 03:18:53PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 08, 2015 at 03:38:46PM +0800, Yuanhan Liu wrote: > > From: Ouyang Changchun > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple que

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:38:46PM +0800, Yuanhan Liu wrote: > From: Ouyang Changchun > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. > > What diff

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Yuanhan Liu
On Wed, Sep 09, 2015 at 08:05:11AM +, Ouyang, Changchun wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Tuesday, September 8, 2015 3:39 PM > > To: qemu-devel@nongnu.org > > Cc: m...@redhat.com; Ouyang, Changchun; Yuanhan Liu > > S

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Ouyang, Changchun
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Tuesday, September 8, 2015 3:39 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Ouyang, Changchun; Yuanhan Liu > Subject: [PATCH 6/7] vhost-user: add multiple queue support > > From: Ouyang Changc

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-08 Thread Yuanhan Liu
On Tue, Sep 08, 2015 at 03:22:30PM -0600, Eric Blake wrote: > On 09/08/2015 01:38 AM, Yuanhan Liu wrote: > > From: Ouyang Changchun > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple queue support, > > by creatin

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-08 Thread Eric Blake
On 09/08/2015 01:38 AM, Yuanhan Liu wrote: > From: Ouyang Changchun > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. > Reviewing grammar and interf