Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

2015-03-12 Thread Juan Quintela
Amit Shah wrote: > On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote: >> It has always been a page header, not a block header. Once there, the >> flag argument was only passed to make a bit or with it, just do the or >> on the caller. > > I prefer not to do that -- if one looks at the function

Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

2015-02-24 Thread Amit Shah
On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote: > It has always been a page header, not a block header. Once there, the > flag argument was only passed to make a bit or with it, just do the or > on the caller. I prefer not to do that -- if one looks at the function signature, he'll only not