Re: [Qemu-devel] [PATCH 5/9] QemuOpts: Convert qemu_opts_foreach() to Error

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 14:34, Eric Blake wrote: > Or, you could do: > > if (!errp) { errp = &error_abort; } ... if (rc) { return rc; } > assert(!*errp); > > and not have to use error_propagate() - either the caller is > tracking errors, or the caller passed NULL because they are > tracking return value

Re: [Qemu-devel] [PATCH 5/9] QemuOpts: Convert qemu_opts_foreach() to Error

2015-06-02 Thread Eric Blake
On 06/02/2015 05:33 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 05/28/2015 06:21 AM, Markus Armbruster wrote: >>> Retain the function value for now, to permit selective conversion of >>> its callers. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> -typedef int (*qemu_opts_loo

Re: [Qemu-devel] [PATCH 5/9] QemuOpts: Convert qemu_opts_foreach() to Error

2015-06-02 Thread Markus Armbruster
Eric Blake writes: > On 05/28/2015 06:21 AM, Markus Armbruster wrote: >> Retain the function value for now, to permit selective conversion of >> its callers. >> >> Signed-off-by: Markus Armbruster >> --- >> block/blkdebug.c | 6 ++-- >> hw/core/qdev-properties-system.c | 5 +-

Re: [Qemu-devel] [PATCH 5/9] QemuOpts: Convert qemu_opts_foreach() to Error

2015-05-28 Thread Eric Blake
On 05/28/2015 06:21 AM, Markus Armbruster wrote: > Retain the function value for now, to permit selective conversion of > its callers. > > Signed-off-by: Markus Armbruster > --- > block/blkdebug.c | 6 ++-- > hw/core/qdev-properties-system.c | 5 +-- > include/qemu/option.h