On 2018-08-28 22:25, John Snow wrote:
>
>
> On 08/25/2018 11:02 AM, Max Reitz wrote:
>> If you say so... I have to admit I don't really understand. The
>> comment doesn't explain why it's so important to keep src around until
>> job_completed(), so I don't know. I thought AioContexts are recur
On 08/25/2018 11:02 AM, Max Reitz wrote:
> On 2018-08-23 00:05, John Snow wrote:
>>
>>
>> On 08/22/2018 08:15 AM, Max Reitz wrote:
>>> On 2018-08-17 21:04, John Snow wrote:
Change the manual deferment to mirror_exit into the implicit
callback to job_exit and the mirror_exit callback.
>
On 08/25/2018 11:02 AM, Max Reitz wrote:
> If you say so... I have to admit I don't really understand. The
> comment doesn't explain why it's so important to keep src around until
> job_completed(), so I don't know. I thought AioContexts are recursive
> so it doesn't matter whether you take t
On 2018-08-25 17:02, Max Reitz wrote:
> On 2018-08-23 00:05, John Snow wrote:
>>
>>
>> On 08/22/2018 08:15 AM, Max Reitz wrote:
>>> On 2018-08-17 21:04, John Snow wrote:
Change the manual deferment to mirror_exit into the implicit
callback to job_exit and the mirror_exit callback.
>>
On 2018-08-23 00:05, John Snow wrote:
>
>
> On 08/22/2018 08:15 AM, Max Reitz wrote:
>> On 2018-08-17 21:04, John Snow wrote:
>>> Change the manual deferment to mirror_exit into the implicit
>>> callback to job_exit and the mirror_exit callback.
>>>
>>> This does change the order of some bdrv_unr
On 08/22/2018 08:15 AM, Max Reitz wrote:
> On 2018-08-17 21:04, John Snow wrote:
>> Change the manual deferment to mirror_exit into the implicit
>> callback to job_exit and the mirror_exit callback.
>>
>> This does change the order of some bdrv_unref calls and job_completed,
>> but thanks to the
On 2018-08-17 21:04, John Snow wrote:
> Change the manual deferment to mirror_exit into the implicit
> callback to job_exit and the mirror_exit callback.
>
> This does change the order of some bdrv_unref calls and job_completed,
> but thanks to the new context in which we call .job_exit, this is s
On 2018-08-17 21:04, John Snow wrote:
> Change the manual deferment to mirror_exit into the implicit
> callback to job_exit and the mirror_exit callback.
>
> This does change the order of some bdrv_unref calls and job_completed,
> but thanks to the new context in which we call .job_exit, this is s
