Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-07-19 Thread Luiz Capitulino
On Thu, 19 Jul 2012 10:17:10 +0200 Kevin Wolf wrote: > Am 19.07.2012 04:20, schrieb Dong Xu Wang: > > On Thu, Jun 14, 2012 at 7:33 PM, Kevin Wolf wrote: > >> Am 14.06.2012 13:18, schrieb Paolo Bonzini: > >>> Il 14/06/2012 12:59, Kevin Wolf ha scritto: > Am 13.06.2012 16:36, schrieb Dong Xu

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-07-19 Thread Stefan Hajnoczi
On Thu, Jul 19, 2012 at 3:20 AM, Dong Xu Wang wrote: > On Thu, Jun 14, 2012 at 7:33 PM, Kevin Wolf wrote: >> Am 14.06.2012 13:18, schrieb Paolo Bonzini: >>> Il 14/06/2012 12:59, Kevin Wolf ha scritto: Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow will let raw file support snapshot

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-07-19 Thread Kevin Wolf
Am 19.07.2012 04:20, schrieb Dong Xu Wang: > On Thu, Jun 14, 2012 at 7:33 PM, Kevin Wolf wrote: >> Am 14.06.2012 13:18, schrieb Paolo Bonzini: >>> Il 14/06/2012 12:59, Kevin Wolf ha scritto: Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow will let raw file support snapshot_blkdev ind

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-07-18 Thread Dong Xu Wang
On Thu, Jun 14, 2012 at 7:33 PM, Kevin Wolf wrote: > Am 14.06.2012 13:18, schrieb Paolo Bonzini: >> Il 14/06/2012 12:59, Kevin Wolf ha scritto: >>> Am 13.06.2012 16:36, schrieb Dong Xu Wang: add-cow will let raw file support snapshot_blkdev indirectly. Signed-off-by: Dong Xu Wang >

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Kevin Wolf
Am 14.06.2012 13:18, schrieb Paolo Bonzini: > Il 14/06/2012 12:59, Kevin Wolf ha scritto: >> Am 13.06.2012 16:36, schrieb Dong Xu Wang: >>> add-cow will let raw file support snapshot_blkdev indirectly. >>> >>> Signed-off-by: Dong Xu Wang >> >> Paolo, what do you think about this magic? > > Beside

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Paolo Bonzini
Il 14/06/2012 12:59, Kevin Wolf ha scritto: > Am 13.06.2012 16:36, schrieb Dong Xu Wang: >> add-cow will let raw file support snapshot_blkdev indirectly. >> >> Signed-off-by: Dong Xu Wang > > Paolo, what do you think about this magic? Besides the obvious layering violation (it would be better to

Re: [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev

2012-06-14 Thread Kevin Wolf
Am 13.06.2012 16:36, schrieb Dong Xu Wang: > add-cow will let raw file support snapshot_blkdev indirectly. > > Signed-off-by: Dong Xu Wang Paolo, what do you think about this magic? I think I can see its use especially for HMP because it's quite convenient, but on the other hand it assumes a fi