Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-14 Thread Luiz Capitulino
On Wed, 14 Sep 2011 19:55:25 + Blue Swirl wrote: > On Wed, Sep 14, 2011 at 3:06 AM, Luiz Capitulino > wrote: > > On Fri,  9 Sep 2011 17:25:41 -0300 > > Luiz Capitulino wrote: > > > >> This commit could have been folded with the previous one, however > >> doing it separately will allow for

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-14 Thread Blue Swirl
On Wed, Sep 14, 2011 at 3:06 AM, Luiz Capitulino wrote: > On Fri,  9 Sep 2011 17:25:41 -0300 > Luiz Capitulino wrote: > >> This commit could have been folded with the previous one, however >> doing it separately will allow for easy bisect and revert if needed. >> >> Checking and testing all valid

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-13 Thread Luiz Capitulino
On Fri, 9 Sep 2011 17:25:41 -0300 Luiz Capitulino wrote: > This commit could have been folded with the previous one, however > doing it separately will allow for easy bisect and revert if needed. > > Checking and testing all valid transitions wasn't trivial, chances > are this will need broader

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-09 Thread Luiz Capitulino
On Tue, 06 Sep 2011 19:42:15 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Tue, 06 Sep 2011 17:55:12 +0200 > > Jan Kiszka wrote: > > >> On 2011-09-06 15:14, Luiz Capitulino wrote: > >> > This commit could have been folded with the previous one, however > >> > doing it separate

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-06 Thread Lluís Vilanova
Luiz Capitulino writes: > On Tue, 06 Sep 2011 17:55:12 +0200 > Jan Kiszka wrote: >> On 2011-09-06 15:14, Luiz Capitulino wrote: >> > This commit could have been folded with the previous one, however >> > doing it separately will allow for easy bisect and revert if needed. >> > >> > Checking and

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-06 Thread Luiz Capitulino
On Tue, 06 Sep 2011 17:55:12 +0200 Jan Kiszka wrote: > On 2011-09-06 15:14, Luiz Capitulino wrote: > > This commit could have been folded with the previous one, however > > doing it separately will allow for easy bisect and revert if needed. > > > > Checking and testing all valid transitions was

Re: [Qemu-devel] [PATCH 4/9] runstate_set(): Check for valid transitions

2011-09-06 Thread Jan Kiszka
On 2011-09-06 15:14, Luiz Capitulino wrote: > This commit could have been folded with the previous one, however > doing it separately will allow for easy bisect and revert if needed. > > Checking and testing all valid transitions wasn't trivial, chances > are this will need broader testing to beco