Re: [Qemu-devel] [PATCH 4/5] virtiofsd: drop lo_dirp->fd field

2019-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2019 at 06:27:16PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > fdopendir(3) takes ownership of the file descriptor. The presence of > > the lo_dirp->fd field could lead to someone incorrectly adding a > > close(d->fd) cleanup call in th

Re: [Qemu-devel] [PATCH 4/5] virtiofsd: drop lo_dirp->fd field

2019-07-31 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > fdopendir(3) takes ownership of the file descriptor. The presence of > the lo_dirp->fd field could lead to someone incorrectly adding a > close(d->fd) cleanup call in the future. > > Do not store the file descriptor in struct lo_dirp since it is un