Re: [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions.

2017-06-12 Thread Gerd Hoffmann
Hi, > It's a bit weird to have win_fb used without being really > initialized. > > Furthermore, there doesn't seem to be guarantee that > glGenFramebuffers(1, &fb->framebuffer) will make only non-0 values. 0 is reserved for the default framebuffer of the current context, i.e. the sdl window in

Re: [Qemu-devel] [PATCH 3/4] sdl2: use framebuffer helper functions.

2017-06-08 Thread Marc-André Lureau
Hi On Tue, Jun 6, 2017 at 3:05 PM Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/ui/sdl2.h | 8 ++-- > ui/sdl2-gl.c | 38 -- > 2 files changed, 14 insertions(+), 32 deletions(-) > > diff --git a/include/ui/sdl2.h b/include/ui/s