Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-02-01 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Check qdev's call to vmstate_register_with_alias_id; that gets > most of the common uses; there's hundreds of calls via vmstate_register > which could get fixed over time. > > Signed-off-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-10 Thread Peter Maydell
On 10 January 2017 at 10:34, Dr. David Alan Gilbert wrote: > However, it's a bit optimistic of the memory region to claim the name > is just for debug; Migration/ram.c transmits the RAMBlock's idstr on > the wire (as does postcopy) - so I think the memory.h comment > is wrong. We'd better fix tha

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-10 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 10 January 2017 at 09:26, Dr. David Alan Gilbert > wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) > >> wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Ch

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-10 Thread Peter Maydell
On 10 January 2017 at 09:26, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) >> wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Check qdev's call to vmstate_register_with_alias_id; that gets >> > m

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-10 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > > > Check qdev's call to vmstate_register_with_alias_id; that gets > > most of the common uses; there's hundreds of calls via vmstate_regist

Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values

2017-01-09 Thread Peter Maydell
On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check qdev's call to vmstate_register_with_alias_id; that gets > most of the common uses; there's hundreds of calls via vmstate_register > which could get fixed over time. Not quite that bad, I t