Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 15:53, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 19/10/2012 14:44, Markus Armbruster ha scritto: >>> Apropos hotplug. The only way to unexport a block device is to stop the >>> NBD server outright. Once the device backend has been exported, >>> unplugging the d

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini writes: > Il 19/10/2012 14:44, Markus Armbruster ha scritto: >> Apropos hotplug. The only way to unexport a block device is to stop the >> NBD server outright. Once the device backend has been exported, >> unplugging the device gets rid of the frontend, but the backend stays >> un

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 04:58:45 -0400 (EDT) Paolo Bonzini wrote: > > > Why's nbd_server_add not needed in HMP? > > > > Oh, it's because HMP's nbd_server_start auto-adds *all* block > > devices, unlinke QMP's nbd-server-start. > > > > Are you sure that's a good idea? > > Yes. Now that we have QM

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini writes: >> Why's nbd_server_add not needed in HMP? >> >> Oh, it's because HMP's nbd_server_start auto-adds *all* block >> devices, unlinke QMP's nbd-server-start. >> >> Are you sure that's a good idea? > > Yes. Now that we have QMP we can go back and treat HMP as (mostly) a > deb

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 14:44, Markus Armbruster ha scritto: > Apropos hotplug. The only way to unexport a block device is to stop the > NBD server outright. Once the device backend has been exported, > unplugging the device gets rid of the frontend, but the backend stays > until you stop the NBD server, o

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Paolo Bonzini
> Why's nbd_server_add not needed in HMP? > > Oh, it's because HMP's nbd_server_start auto-adds *all* block > devices, unlinke QMP's nbd-server-start. > > Are you sure that's a good idea? Yes. Now that we have QMP we can go back and treat HMP as (mostly) a debugging interface as it was meant t

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini writes: > Acked-by: Luiz Capitulino > Signed-off-by: Paolo Bonzini > --- > hmp-commands.hx | 29 + > hmp.c | 55 +++ > hmp.h | 2 ++ > 3 file modificati, 86 inserzioni(+) > > diff