Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-05-10 Thread Anthony Liguori
On 05/10/2012 05:01 AM, Andreas Färber wrote: Am 10.05.2012 09:05, schrieb Paolo Bonzini: Il 09/05/2012 22:01, Igor Mammedov ha scritto: Hi Paolo, Are you plannig to respin this and related patches? If yes, when? After the first part goes in (21 patches including Anthony's bus series). A re

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-05-10 Thread Andreas Färber
Am 10.05.2012 09:05, schrieb Paolo Bonzini: > Il 09/05/2012 22:01, Igor Mammedov ha scritto: >> Hi Paolo, >> >> Are you plannig to respin this and related patches? >> If yes, when? > > After the first part goes in (21 patches including Anthony's bus > series). A reviewed-by from Andreas or Anthon

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-05-10 Thread Paolo Bonzini
Il 09/05/2012 22:01, Igor Mammedov ha scritto: > Hi Paolo, > > Are you plannig to respin this and related patches? > If yes, when? After the first part goes in (21 patches including Anthony's bus series). A reviewed-by from Andreas or Anthony would help, so that I can make Andreas's suggested do

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-05-09 Thread Igor Mammedov
Hi Paolo, Are you plannig to respin this and related patches? If yes, when? On Tue, Apr 03, 2012 at 01:15:51PM +0200, Paolo Bonzini wrote: > Since we had to move the state field from DeviceState to Object, we cannot > delay the implementation of the "realized" property. The property is > a trigg

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Andreas Färber
Am 03.04.2012 15:03, schrieb Paolo Bonzini: > Il 03/04/2012 14:11, Andreas Färber ha scritto: >> Since this patch is clearly an extended version of my realize patch >> http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as >> reminded last night. If you don't want my SoB on the parts

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Anthony Liguori
Hi, I'm about to board a plane but I at least want to comment that we should all give each other the benefit of the doubt in a situation like this. Everyone on this thread is a long term contributer to QEMU that has more than earned the right not to be accussed of impropriety. Let's all take a de

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 15:31, Andreas Färber ha scritto: > Here's how I see it: > > * You add a realize callback to ObjectClass like I did, you add the > Error** parameter that was requested as feedback to mine. > * You add a static object_realize() method that clashes with my > introducing it as a public

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Andreas Färber
Am 05.04.2012 14:36, schrieb Paolo Bonzini: > Il 05/04/2012 14:04, Andreas Färber ha scritto: >> Am 03.04.2012 15:03, schrieb Paolo Bonzini: >>> Il 03/04/2012 14:11, Andreas Färber ha scritto: Since this patch is clearly an extended version of my realize patch http://patchwork.ozlabs.org/

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-05 Thread Paolo Bonzini
Il 05/04/2012 14:04, Andreas Färber ha scritto: > Am 03.04.2012 15:03, schrieb Paolo Bonzini: >> Il 03/04/2012 14:11, Andreas Färber ha scritto: >>> Since this patch is clearly an extended version of my realize patch >>> http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as >>> remi

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 14:11, Andreas Färber ha scritto: > Since this patch is clearly an extended version of my realize patch > http://patchwork.ozlabs.org/patch/148752/, it should carry my SoB, as > reminded last night. If you don't want my SoB on the parts I didn't do - > namely unrealize and *_childen -

Re: [Qemu-devel] [PATCH 23/25] qom: add realized property

2012-04-03 Thread Andreas Färber
Paolo, Am 03.04.2012 13:15, schrieb Paolo Bonzini: > Since we had to move the state field from DeviceState to Object, we cannot > delay the implementation of the "realized" property. The property is > a trigger for two actions that propagate through the composition tree. > "Realize" is called whe