Re: [Qemu-devel] [PATCH 21/30] migration: move exit condition to migration thread

2012-10-26 Thread Juan Quintela
Paolo Bonzini wrote: > Il 18/10/2012 09:30, Juan Quintela ha scritto: >> -if (s->migration_state->complete) { >> +qemu_mutex_lock_iothread(); > > So, was it a bug that we were accessing ->complete without the BQL? > >> +if (m->state != MIG_STATE_ACTIVE) { >> +DP

Re: [Qemu-devel] [PATCH 21/30] migration: move exit condition to migration thread

2012-10-18 Thread Paolo Bonzini
Il 18/10/2012 09:30, Juan Quintela ha scritto: > -if (s->migration_state->complete) { > +qemu_mutex_lock_iothread(); So, was it a bug that we were accessing ->complete without the BQL? > +if (m->state != MIG_STATE_ACTIVE) { > +DPRINTF("put_ready returning becau