Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513

2015-02-08 Thread Jason Wang
On Sun, Feb 8, 2015 at 6:51 PM, Michael S. Tsirkin wrote: On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: Recent linux kernel supports up to 256 tap queues. Increase the limit to 513 (256 * 2 + 1(ctrl vq)). Signed-off-by: Jason Wang We have a bunch of loops over all poss

Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: > Recent linux kernel supports up to 256 tap queues. Increase the limit > to 513 (256 * 2 + 1(ctrl vq)). > > Signed-off-by: Jason Wang We have a bunch of loops over all possible VQ numbers in virtio pci. Doing this for 1000 VQs when mos

Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513

2015-02-06 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: Subject has a typo s/VIRITIO/VIRTIO/ > Recent linux kernel supports up to 256 tap queues. Increase the limit > to 513 (256 * 2 + 1(ctrl vq)). For other reviewers: sizeof(VirtQueue) on x86_64 is 88 bytes. We waste memory but it's only o