Re: [Qemu-devel] [PATCH 2/5] target-arm: enable get_rw_prot to take simple AP

2015-03-10 Thread Andrew Jones
On Tue, Mar 10, 2015 at 04:41:45PM +, Peter Maydell wrote: > On 10 March 2015 at 16:32, Andrew Jones wrote: > > On Tue, Mar 10, 2015 at 03:22:55PM +, Peter Maydell wrote: > >> I'm confused. Even if we're using the simple-permissions > >> model, the ap parameter is still AP[2:0]. Shouldn't

Re: [Qemu-devel] [PATCH 2/5] target-arm: enable get_rw_prot to take simple AP

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 16:32, Andrew Jones wrote: > On Tue, Mar 10, 2015 at 03:22:55PM +, Peter Maydell wrote: >> I'm confused. Even if we're using the simple-permissions >> model, the ap parameter is still AP[2:0]. Shouldn't this >> switch be for cases 0, 2, 4, 6 ? > > Depends on how we choose t

Re: [Qemu-devel] [PATCH 2/5] target-arm: enable get_rw_prot to take simple AP

2015-03-10 Thread Andrew Jones
On Tue, Mar 10, 2015 at 03:22:55PM +, Peter Maydell wrote: > On 12 February 2015 at 15:05, Andrew Jones wrote: > > Teach get_rw_prot about the simple AP format AP[2:1]. An additional > > switch was added, as opposed to converting ap := AP[2:1] to AP[2:0] > > with a simple shift - and then modi

Re: [Qemu-devel] [PATCH 2/5] target-arm: enable get_rw_prot to take simple AP

2015-03-10 Thread Peter Maydell
On 12 February 2015 at 15:05, Andrew Jones wrote: > Teach get_rw_prot about the simple AP format AP[2:1]. An additional > switch was added, as opposed to converting ap := AP[2:1] to AP[2:0] > with a simple shift - and then modifying cases 0,2,4,6, because the > resulting code is easier to read wit