On 15 February 2013 15:14, Paolo Bonzini wrote:
> I like the empty-except-for-parentclass. OTOH, if you have no fields
> you will not use FOO_CLASS. You will only use PARENT_CLASS, and those
> uses will be fine even after you start having a FooClass.
OK, that makes sense I think, except there i
Am 15.02.2013 16:14, schrieb Paolo Bonzini:
> Il 15/02/2013 14:48, Peter Maydell ha scritto:
>> If you prefer we could standardize on
>> typedef struct {
>> ParentClass parent;
>> } FooClass;
>>
>> rather than typedef ParentClass FooClass;
It may need rework e
Il 15/02/2013 14:48, Peter Maydell ha scritto:
>>> >> If you prefer we could standardize on
>>> >> typedef struct {
>>> >> ParentClass parent;
>>> >> } FooClass;
>>> >>
>>> >> rather than typedef ParentClass FooClass;
>> > It may need rework either way. Because aliasing via typedef gives
On 15 February 2013 13:45, Andreas Färber wrote:
> Am 15.02.2013 14:38, schrieb Peter Maydell:
>> On 15 February 2013 13:11, Andreas Färber wrote:
>>> Am 15.02.2013 12:45, schrieb Peter Maydell:
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1031,6 +1031,21 @@ static const TypeInfo mv
On 15 February 2013 13:11, Andreas Färber wrote:
> Am 15.02.2013 12:45, schrieb Peter Maydell:
>> --- a/hw/musicpal.c
>> +++ b/hw/musicpal.c
>> @@ -1031,6 +1031,21 @@ static const TypeInfo mv88w8618_flashcfg_info = {
>>
>> #define MP_BOARD_REVISION 0x31
>>
>> +typedef struct {
>
> Anonymous
Am 15.02.2013 14:38, schrieb Peter Maydell:
> On 15 February 2013 13:11, Andreas Färber wrote:
>> Am 15.02.2013 12:45, schrieb Peter Maydell:
>>> --- a/hw/musicpal.c
>>> +++ b/hw/musicpal.c
>>> @@ -1031,6 +1031,21 @@ static const TypeInfo mv88w8618_flashcfg_info = {
>>>
>>> #define MP_BOARD_REVIS
Am 15.02.2013 12:45, schrieb Peter Maydell:
> Make musicpal-misc into its own (trivial) qdev device, so we
> can get rid of the abuse of sysbus_add_memory().
>
> Signed-off-by: Peter Maydell
> ---
> hw/musicpal.c | 34 +-
> 1 file changed, 29 insertions(+), 5 de