Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Peter Lieven
Am 03.09.2015 um 13:52 schrieb Gerd Hoffmann: Hi, Beside that I think it makes sense to have the shrinking logic in buffer_reserve too so we don't have to add buffer_shrink calls all over the place. We need a possibility to shrink the buffer after it has been used. Especially the queue->buf

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Peter Lieven
Am 03.09.2015 um 13:57 schrieb Gerd Hoffmann: Hi, buffer_reserve: 11/t-tight: 4096 kB buffer_reserve: 11/t-tight: 8192 kB buffer_reserve: 11/t-tight: 16384 kB A bit more than what I see (4096 usually, 8192 once). No idea why. buffer_reserve: queue : 8192 kB buffer_reserve: 11/jobs

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Gerd Hoffmann
Hi, > buffer_reserve: 11/t-tight: 4096 kB > buffer_reserve: 11/t-tight: 8192 kB > buffer_reserve: 11/t-tight: 16384 kB A bit more than what I see (4096 usually, 8192 once). No idea why. > buffer_reserve: queue : 8192 kB > buffer_reserve: 11/jobs : 8192 kB > buffer_reserve: 11/out: 8

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Gerd Hoffmann
Hi, > > Beside that I think it makes sense to have the shrinking logic in > > buffer_reserve too so we don't have to add buffer_shrink calls all over > > the place. > > We need a possibility to shrink the buffer after it has been used. > Especially the queue->buffer. That works fine. Test pat

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Peter Lieven
Am 03.09.2015 um 11:52 schrieb Gerd Hoffmann: On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: currently the Buffer can only grow. This increases Qemu memory footprint dramatically since normally the biggest VNC updates ar

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Peter Lieven
Am 03.09.2015 um 11:52 schrieb Gerd Hoffmann: On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: currently the Buffer can only grow. This increases Qemu memory footprint dramatically since normally the biggest VNC updates ar

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-09-03 Thread Gerd Hoffmann
On Do, 2015-08-27 at 11:39 +0100, Daniel P. Berrange wrote: > On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: > > currently the Buffer can only grow. This increases Qemu memory footprint > > dramatically since normally the biggest VNC updates are at connection time. > > But also after

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-08-27 Thread Peter Lieven
Am 27.08.2015 um 12:39 schrieb Daniel P. Berrange: On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: currently the Buffer can only grow. This increases Qemu memory footprint dramatically since normally the biggest VNC updates are at connection time. But also after a VNC session has t

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: > currently the Buffer can only grow. This increases Qemu memory footprint > dramatically since normally the biggest VNC updates are at connection time. > But also after a VNC session has terminated there is one persistent buffer > in qu