Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-09 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 09:51:53AM -0400, Paolo Bonzini wrote: > > > Thanks a lot! These are the patches I have pending for review: > > > > - [PATCH qemu 0/2] monitor/ppc: Print correct SPRs > > CCing PPC maintainer (who's also on leave, but can suggest someone). > > > - [PATCH] trace-events: A

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-09 Thread Pavel Butsykin
On 08.09.2015 13:13, Fam Zheng wrote: On Tue, 09/08 11:54, Paolo Bonzini wrote: On 08/09/2015 09:09, Denis V. Lunev wrote: qemu-monitor-info.texi | 151 +++ This should be added in patch 4, not now. +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); + +const

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Paolo Bonzini
> Thanks a lot! These are the patches I have pending for review: > > - [PATCH qemu 0/2] monitor/ppc: Print correct SPRs CCing PPC maintainer (who's also on leave, but can suggest someone). > - [PATCH] trace-events: Add hmp completion CCing trace maintainer. > - [PATCH v3 0/4] Move target- and

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Luiz Capitulino
On Tue, 8 Sep 2015 09:04:56 -0400 (EDT) Paolo Bonzini wrote: > > > > This should be added in patch 4, not now. > > > > > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > > > > + > > > > +const MonitorDef *target_monitor_defs(void) > > > > +{ > > > > +return NULL; >

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Paolo Bonzini
> > This should be added in patch 4, not now. > > > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > > > + > > > +const MonitorDef *target_monitor_defs(void) > > > +{ > > > +return NULL; > > > +} > > > > Weak symbols do not work on all platforms. Luckily, making lib

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Luiz Capitulino
On Tue, 8 Sep 2015 11:54:46 +0200 Paolo Bonzini wrote: > > > On 08/09/2015 09:09, Denis V. Lunev wrote: > > qemu-monitor-info.texi | 151 +++ > > This should be added in patch 4, not now. > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > > + > > +const

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Fam Zheng
On Tue, 09/08 11:54, Paolo Bonzini wrote: > > > On 08/09/2015 09:09, Denis V. Lunev wrote: > > qemu-monitor-info.texi | 151 +++ > > This should be added in patch 4, not now. > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > > + > > +const MonitorDef *tar

Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

2015-09-08 Thread Paolo Bonzini
On 08/09/2015 09:09, Denis V. Lunev wrote: > qemu-monitor-info.texi | 151 +++ This should be added in patch 4, not now. > +const MonitorDef *target_monitor_defs(void) __attribute__((weak)); > + > +const MonitorDef *target_monitor_defs(void) > +{ > +return NULL; > +} Weak sym