Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:03 AM, Hans de Goede wrote: Hi, On 08/08/2011 02:52 PM, Anthony Liguori wrote: On 08/08/2011 03:01 AM, Hans de Goede wrote: So after my char-flow changes, you won't be allowed to set handlers unless you've called open. Why not do it the other way around? So don't allow

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Hans de Goede
Hi, On 08/08/2011 02:52 PM, Anthony Liguori wrote: On 08/08/2011 03:01 AM, Hans de Goede wrote: So after my char-flow changes, you won't be allowed to set handlers unless you've called open. Why not do it the other way around? So don't allow open until the handlers are set. My reasoning

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Anthony Liguori
On 08/08/2011 03:01 AM, Hans de Goede wrote: Hi, On 08/07/2011 11:30 PM, Anthony Liguori wrote: On 08/07/2011 12:41 PM, Hans de Goede wrote: Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving dat

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Hans de Goede
Hi, On 08/07/2011 11:30 PM, Anthony Liguori wrote: On 08/07/2011 12:41 PM, Hans de Goede wrote: Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-07 Thread Anthony Liguori
On 08/07/2011 12:41 PM, Hans de Goede wrote: Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev to get it registered with the spice-server. Signed-

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-07 Thread Hans de Goede
Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev to get it registered with the spice-server. Signed-off-by: Hans de Goede --- usb-redir.c | 3 +++

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-07 Thread Anthony Liguori
On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving data. This is necessary with the spicevmc chardev to get it registered with the spice-server. Signed-off-by: Hans de Goede --- usb-redir.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(