Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable warning

2011-06-01 Thread Christophe Fergeau
On Wed, Jun 01, 2011 at 09:53:46AM -0600, David Ahern wrote: > I think you want those to be ehci->pid instead of deleting them. Yeah, this is exactly what I was wondering while making this patch, but couldn't decide which one was supposed to be given my total lack of knowledge of USB and of this c

Re: [Qemu-devel] [PATCH 2/3] ehci: Fix unused-but-set-variable warning

2011-06-01 Thread David Ahern
On 06/01/2011 06:56 AM, Christophe Fergeau wrote: > @@ -1134,11 +1128,8 @@ static int ehci_process_itd(EHCIState *ehci, > > DPRINTF("ISOCH: buffer %08X len %d\n", ptr, len); > > -if (!dir) { > +if (!dir) > cpu_physical_memory_rw(ptr, &ehci->