On Thu, Apr 18, 2013 at 5:00 AM, Wenchao Xia wrote:
> 于 2013-4-17 22:42, Stefan Hajnoczi 写道:
>
>> On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote:
>>>
>>> /* New and old BlockDriverState structs for group snapshots */
>>> -typedef struct BlkTransactionStates {
>>> +typedef struct Bdr
于 2013-4-17 22:42, Stefan Hajnoczi 写道:
On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote:
/* New and old BlockDriverState structs for group snapshots */
-typedef struct BlkTransactionStates {
+typedef struct BdrvActionOps {
+int (*commit)(BlockdevAction *action, void **p_opaque,
On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote:
> /* New and old BlockDriverState structs for group snapshots */
> -typedef struct BlkTransactionStates {
> +typedef struct BdrvActionOps {
> +int (*commit)(BlockdevAction *action, void **p_opaque, Error **errp);
> +void (*rollba
于 2013-4-3 17:02, Wenchao Xia 写道:
No, if bdrv_snapshot_delete() can fail, you need to split it in two
parts: one that can fail, and one that cannot. If you cannot, then
there are two possibilities:
- if the failures are minor and could be repaired with "qemu-img check
-r"
(e.g. lost clusters),
Am 03.04.2013 um 11:02 hat Wenchao Xia geschrieben:
> >
> >No, if bdrv_snapshot_delete() can fail, you need to split it in two
> >parts: one that can fail, and one that cannot. If you cannot, then
> >there are two possibilities:
> >
> >- if the failures are minor and could be repaired with "qemu-i
Il 03/04/2013 11:02, Wenchao Xia ha scritto:
>>
> Sorry I haven't state it clearly. What about bdrv_snapshot_create()
> operation? If it need to be rolled back, I think bdrv_snapshot_delete()
> will get called and it may fail. But in most case if
> bdrv_snapshot_create() succeed before, the bdrv_
No, if bdrv_snapshot_delete() can fail, you need to split it in two
parts: one that can fail, and one that cannot. If you cannot, then
there are two possibilities:
- if the failures are minor and could be repaired with "qemu-img check -r"
(e.g. lost clusters), then this is not optimal but can s
- Messaggio originale -
> Da: "Wenchao Xia"
> A: "Kevin Wolf"
> Cc: pbonz...@redhat.com, qemu-devel@nongnu.org, diet...@proxmox.com,
> stefa...@gmail.com
> Inviato: Mercoledì, 3 aprile 2013 7:51:43
> Oggetto: Re: [Qemu-devel] [PATCH 2/
于 2013-4-2 21:55, Kevin Wolf 写道:
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
Now code for external snapshot are packaged as one case
in qmp_transaction, so later other operation could be added.
The logic in qmp_transaction is changed a bit: Original code
tries to create all images
Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
> Now code for external snapshot are packaged as one case
> in qmp_transaction, so later other operation could be added.
> The logic in qmp_transaction is changed a bit: Original code
> tries to create all images first and then update all *bdr
10 matches
Mail list logo
