Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify

2011-09-01 Thread Peter Maydell
On 1 September 2011 09:50, Avi Kivity wrote: > On 08/31/2011 06:55 PM, Peter Maydell wrote: >> Convert the omap_intc devices to qdev. This includes adding >> a 'revision' property which will be needed for omap3. > This is likely to conflict with my omap1 patches in memory/queue. Quite likely --

Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify

2011-09-01 Thread Avi Kivity
On 08/31/2011 06:55 PM, Peter Maydell wrote: Convert the omap_intc devices to qdev. This includes adding a 'revision' property which will be needed for omap3. The bulk of this patch is the replacement of "s->irq[x][y]" with "qdev_get_gpio_in(s->ih[x], y)" now that the interrupt controller expos

Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify

2011-08-31 Thread Peter Maydell
On 31 August 2011 16:55, Peter Maydell wrote: > Convert the omap_intc devices to qdev. This includes adding > a 'revision' property which will be needed for omap3. Incidentally this patch is a test case for a false positive in checkpatch.pl, which complains: ERROR: need consistent spacing around