Re: [Qemu-devel] [PATCH 17/26] target/s390x: Convert to CPUClass::tlb_fill

2019-05-08 Thread Richard Henderson
On 4/3/19 4:17 AM, David Hildenbrand wrote: >> +/* >> + * Note that handle_mmu_fault sets ilen to either 2 (for code) > This comment no longer matches. > >> + * or AUTO (for data). We can resolve AUTO now, as if it was >> + * set to UNWIND -- that will have been done via assignmen

Re: [Qemu-devel] [PATCH 17/26] target/s390x: Convert to CPUClass::tlb_fill

2019-04-03 Thread David Hildenbrand
> #endif /* CONFIG_USER_ONLY */ > + > +bool s390_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > + MMUAccessType access_type, int mmu_idx, > + bool probe, uintptr_t retaddr) > +{ > +S390CPU *cpu = S390_CPU(cs); > + > +#ifndef CONFIG_USER_ONLY >