Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2015 at 11:07:18AM -0400, John Snow wrote: > On 06/29/2015 10:51 AM, Stefan Hajnoczi wrote: > > On Fri, Jun 26, 2015 at 01:31:12PM -0400, John Snow wrote: > >> On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: > >>> On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: > @@ -

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-29 Thread John Snow
On 06/29/2015 10:51 AM, Stefan Hajnoczi wrote: > On Fri, Jun 26, 2015 at 01:31:12PM -0400, John Snow wrote: >> On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: >>> On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice *ad,

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 01:31:12PM -0400, John Snow wrote: > On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: > >> @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice > >> *ad, uint16_t len) pio_fis[9] = s->hob_lcyl; pio_fis[10]

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-26 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: > On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: >> @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice >> *ad, uint16_t len) pio_fis[9] = s->hob_lcyl; pio_fis[10] = >> s->hob_hcy

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-26 Thread Stefan Hajnoczi
On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: > @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice *ad, uint16_t > len) > pio_fis[9] = s->hob_lcyl; > pio_fis[10] = s->hob_hcyl; > pio_fis[11] = 0; > -pio_fis[12] = cmd_fis[12]; > -pio_fis[13] = cmd_fis[