Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-22 Thread Juan Quintela
Paolo Bonzini wrote: > Always use qemu_file_get_error to detect errors, since that is how > QEMUFile itself drops I/O after an error occurs. There is no need > to propagate and check return values all the time. > > Also remove the "complete" member, since we know that it is set (via > migrate_fd_

Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:34, Juan Quintela ha scritto: > This move buffered_flush() to inside the iothread lock. At least the > commit message needs to be changed. No, it doesn't... Here is the full body of the migration thread: qemu_mutex_lock_iothread(); qemu_savevm_state_begin(s->file, &s->pa

Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-21 Thread Juan Quintela
Paolo Bonzini wrote: > Always use qemu_file_get_error to detect errors, since that is how > QEMUFile itself drops I/O after an error occurs. There is no need > to propagate and check return values all the time. > > Also remove the "complete" member, since we know that it is set (via > migrate_fd_

Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-18 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > Always use qemu_file_get_error to detect errors, since that is how > QEMUFile itself drops I/O after an error occurs. There is no need > to propagate and check return values all the time. > > Also remove the "complete" member, since we know that it i