Re: [Qemu-devel] [PATCH 11/14] timer: generalize ds1338

2018-07-16 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:58AM -0700, Michael Davidsaver wrote: > Add class level handling for address space size > and control register. > > Signed-off-by: Michael Davidsaver Reviewed-by: David Gibson Although I don't love the name "addr_size" - just "nvram_size" seems clearer. > --- >

Re: [Qemu-devel] [PATCH 11/14] timer: generalize ds1338

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Add class level handling for address space size > and control register. > > Signed-off-by: Michael Davidsaver > --- > @@ -206,22 +216,15 @@ static void dsrtc_update(DSRTCState *s) > static int dsrtc_send(I2CSlave *i2c, uint8_t data) > { >