Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-27 Thread Peter Maydell
On 27 June 2011 10:06, Peter Maydell wrote: > On 26 June 2011 12:11, Michael S. Tsirkin wrote: >> On Tue, Jun 14, 2011 at 08:36:33PM +0300, Michael S. Tsirkin wrote: >>> Signed-off-by: Michael S. Tsirkin >> >> Riku, could you fix this up in a way that makes sense please? >> All I really care abo

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-27 Thread Peter Maydell
On 26 June 2011 12:11, Michael S. Tsirkin wrote: > On Tue, Jun 14, 2011 at 08:36:33PM +0300, Michael S. Tsirkin wrote: >> Signed-off-by: Michael S. Tsirkin > > Riku, could you fix this up in a way that makes sense please? > All I really care about is that -Werror build passes with the latest > gc

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-26 Thread Michael S. Tsirkin
On Tue, Jun 14, 2011 at 08:36:33PM +0300, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin Riku, could you fix this up in a way that makes sense please? All I really care about is that -Werror build passes with the latest gcc. -- MST

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 07:32:50AM -0700, Richard Henderson wrote: > On 06/15/2011 01:35 AM, Alexander Graf wrote: > >> -abi_ulong arg5 = 0, arg6 = 0, arg7 = 0, arg8 = 0; > >> +abi_ulong arg5 = 0, arg6 = 0; > >> > >> nb_args = mips_syscall_args[syscal

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Peter Maydell
On 15 June 2011 09:35, Alexander Graf wrote: > > On 14.06.2011, at 19:36, Michael S. Tsirkin wrote: >>     return 0; >> @@ -7058,18 +7056,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long >> arg1, >>     case TARGET_NR_osf_sigprocmask: >>         { >>             abi_ulong mask; >> -  

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Richard Henderson
On 06/15/2011 01:35 AM, Alexander Graf wrote: >> -abi_ulong arg5 = 0, arg6 = 0, arg7 = 0, arg8 = 0; >> +abi_ulong arg5 = 0, arg6 = 0; >> >> nb_args = mips_syscall_args[syscall_num]; >> sp_reg = env->active_tc.gpr[29]; >>

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 10:35:19AM +0200, Alexander Graf wrote: > > On 14.06.2011, at 19:36, Michael S. Tsirkin wrote: > > > Signed-off-by: Michael S. Tsirkin > > --- > > linux-user/flatload.c | 10 ++ > > linux-user/linuxload.c | 25 + > > linux-user/main.c

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 19:36, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > linux-user/flatload.c | 10 ++ > linux-user/linuxload.c | 25 + > linux-user/main.c |6 +++--- > linux-user/signal.c|5 - > linux-user/syscall.c