Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-31 Thread John Snow
On 08/31/2015 06:21 PM, Eric Blake wrote: > On 06/08/2015 09:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Persistent dirty bitmaps will be saved into qcow2 files. It may be used >> as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for >>

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-31 Thread Eric Blake
On 06/08/2015 09:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero di

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-24 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other dri

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-24 Thread Vladimir Sementsov-Ogievskiy
About structs and constraints: == Optional Header == 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should not exist at all. Should it instead be 0 - 65536 64bit dirty_bitmaps_offset valid: any, but dirty_bitmaps_offse

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-24 Thread Vladimir Sementsov-Ogievskiy
Sorry, drop this if you, look at the new version of this litter On 24.08.2015 16:30, Vladimir Sementsov-Ogievskiy wrote: About structs and constraints: Optional Header: 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should n

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-08-24 Thread Vladimir Sementsov-Ogievskiy
About structs and constraints: Optional Header: 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should not exist at all. Should it instead be 0 - 65536 64bit dirty_bitmaps_offset valid: any, but dirty_bitmaps_offset % cl

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-12 Thread John Snow
On 06/12/2015 06:28 AM, Stefan Hajnoczi wrote: > On Thu, Jun 11, 2015 at 12:21:31PM -0400, John Snow wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> >> >> On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: >>> On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir >>> Sementsov-Ogievsk

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-12 Thread Stefan Hajnoczi
On Thu, Jun 11, 2015 at 12:21:31PM -0400, John Snow wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: > > On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir > > Sementsov-Ogievskiy wrote: > >> On 10.06.2015 16:24, Stefan Hajnoczi wr

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-12 Thread Kevin Wolf
Am 11.06.2015 um 18:30 hat John Snow geschrieben: > On 06/11/2015 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: > > On 10.06.2015 18:34, Kevin Wolf wrote: > >> Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>> +=== Bitmap table === > >>> + > >>> +A directory of all bitmaps

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread John Snow
On 06/11/2015 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: > On 10.06.2015 18:34, Kevin Wolf wrote: >> Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Persistent dirty bitmaps will be saved into qcow2 files. It may be used >>>

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: > On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir > Sementsov-Ogievskiy wrote: >> On 10.06.2015 16:24, Stefan Hajnoczi wrote: >>> On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir >>> Sementsov-Ogi

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Stefan Hajnoczi
On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 10.06.2015 16:24, Stefan Hajnoczi wrote: > >On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>On 09.06.2015 20:03, Stefan Hajnoczi wrote: > >>>On Mon, Jun 08, 2015 at 06:21:19PM +0300,

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other dri

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -166,6 +167,19 @@ the header extension data. Ea

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:00, Eric Blake wrote: On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: +Dirty bitmaps is an optional header extension. It provides a possibility of +storing dirty bitmaps in qcow2 image. The fields are: + + 0 - 3: nb_dirty_bitmaps + Numbe

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Kevin Wolf
Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file wit

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 09.06.2015 20:03, Stefan Hajnoczi wrote: > >On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>@@ -166,6 +167,19 @@ the header extension data. Each entry look like this: > >>

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Eric Blake
On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +Dirty bitmaps is an optional header extension. It provides a >>> possibility of >>> +storing dirty bitmaps in qcow2 image. The fields are: >>> + >>> + 0 - 3: nb_dirty_bitmaps >>> + Number of dirty bitmaps

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 11:19, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'int

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Vladimir Sementsov-Ogievskiy
On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-09 Thread Stefan Hajnoczi
On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-09 Thread John Snow
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-01-27 Thread Eric Blake
On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy wrote: > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero disk size but with > several dirty bitmaps