Re: [Qemu-devel] [PATCH 1/5] xilinx: Fix error handling

2017-07-06 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Jul 05, 2017 at 01:44:35PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Assigning directly to *errp is not valid, as errp may be NULL, >> > &error_fatal, or &error_abort. Use error_propagate() instead. >> > >> > error_propagate() handles

Re: [Qemu-devel] [PATCH 1/5] xilinx: Fix error handling

2017-07-06 Thread Eduardo Habkost
On Wed, Jul 05, 2017 at 01:44:35PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Assigning directly to *errp is not valid, as errp may be NULL, > > &error_fatal, or &error_abort. Use error_propagate() instead. > > > > error_propagate() handles non-NULL *errp correctly, so the >

Re: [Qemu-devel] [PATCH 1/5] xilinx: Fix error handling

2017-07-05 Thread Markus Armbruster
Eduardo Habkost writes: > Assigning directly to *errp is not valid, as errp may be NULL, > &error_fatal, or &error_abort. Use error_propagate() instead. > > error_propagate() handles non-NULL *errp correctly, so the > "if (!*errp)" check can be removed. > > Cc: "Edgar E. Iglesias" > Cc: Alistai

Re: [Qemu-devel] [PATCH 1/5] xilinx: Fix error handling

2017-06-08 Thread Alistair Francis
On Thu, Jun 8, 2017 at 6:39 AM, Eduardo Habkost wrote: > Assigning directly to *errp is not valid, as errp may be NULL, > &error_fatal, or &error_abort. Use error_propagate() instead. > > error_propagate() handles non-NULL *errp correctly, so the > "if (!*errp)" check can be removed. > > Cc: "Edg