Re: [Qemu-devel] [PATCH 1/5] block: Add BDS.never_freeze

2019-07-02 Thread Max Reitz
On 02.07.19 17:36, Alberto Garcia wrote: > On Fri 28 Jun 2019 12:32:51 AM CEST, Max Reitz wrote: >> The commit and the mirror block job must be able to drop their filter >> node at any point. However, this will not be possible if any of the >> BdrvChild links to them is frozen. Therefore, we need

Re: [Qemu-devel] [PATCH 1/5] block: Add BDS.never_freeze

2019-07-02 Thread Alberto Garcia
On Fri 28 Jun 2019 12:32:51 AM CEST, Max Reitz wrote: > The commit and the mirror block job must be able to drop their filter > node at any point. However, this will not be possible if any of the > BdrvChild links to them is frozen. Therefore, we need to prevent them > from ever becoming frozen.

Re: [Qemu-devel] [PATCH 1/5] block: Add BDS.never_freeze

2019-07-02 Thread Max Reitz
On 02.07.19 16:02, Alberto Garcia wrote: > On Fri 28 Jun 2019 12:32:51 AM CEST, Max Reitz wrote: >> @@ -4416,6 +4416,14 @@ int bdrv_freeze_backing_chain(BlockDriverState *bs, >> BlockDriverState *base, >> return -EPERM; >> } >> >> +for (i = bs; i != base; i = backing_bs(i)) { >

Re: [Qemu-devel] [PATCH 1/5] block: Add BDS.never_freeze

2019-07-02 Thread Alberto Garcia
On Fri 28 Jun 2019 12:32:51 AM CEST, Max Reitz wrote: > @@ -4416,6 +4416,14 @@ int bdrv_freeze_backing_chain(BlockDriverState *bs, > BlockDriverState *base, > return -EPERM; > } > > +for (i = bs; i != base; i = backing_bs(i)) { > +if (i->backing && backing_bs(i)->never_

Re: [Qemu-devel] [PATCH 1/5] block: Add BDS.never_freeze

2019-07-01 Thread Andrey Shinkevich
On 28/06/2019 01:32, Max Reitz wrote: > The commit and the mirror block job must be able to drop their filter > node at any point. However, this will not be possible if any of the > BdrvChild links to them is frozen. Therefore, we need to prevent them > from ever becoming frozen. > > Signed-of