Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine

2019-07-01 Thread Michael S. Tsirkin
On Fri, Jun 28, 2019 at 11:44:07PM +0200, Sergio Lopez wrote: > > Eduardo Habkost writes: > > > On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote: > > [...] > >> /* Enables contiguous-apic-ID mode, for compatibility */ > >> -static bool compat_apic_id_mode; > >> +bool compat_apic_id_

Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine

2019-06-28 Thread Sergio Lopez
Eduardo Habkost writes: > On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote: > [...] >> /* Enables contiguous-apic-ID mode, for compatibility */ >> -static bool compat_apic_id_mode; >> +bool compat_apic_id_mode; > > We can get rid of this global variable, see the patch I have just >

Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine

2019-06-28 Thread Eduardo Habkost
On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote: [...] > /* Enables contiguous-apic-ID mode, for compatibility */ > -static bool compat_apic_id_mode; > +bool compat_apic_id_mode; We can get rid of this global variable, see the patch I have just sent: [PATCH] pc: Move compat_apic_i