Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-18 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 07:10:52PM +, Herve Poussineau wrote: > From: Herv? Poussineau > > This option is described in RFC 1783. As this is only an optional field, > we may ignore it in some situations and handle it in some others. > Here, if client requests a block size bigger than the block

Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-17 Thread Stefan Hajnoczi
On Sun, Apr 17, 2011 at 7:16 PM, Hervé Poussineau wrote: > Hi, > > Yes, I've tried booting with PXELINUX and gPXE, and I didn't see any > problem. Great. Thanks for confirming. Stefan

Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-17 Thread Hervé Poussineau
Hi, Yes, I've tried booting with PXELINUX and gPXE, and I didn't see any problem. Hervé Stefan Hajnoczi a écrit : On Mon, Apr 11, 2011 at 07:10:52PM +, Herve Poussineau wrote: From: Herv? Poussineau This option is described in RFC 1783. As this is only an optional field, we may ign

Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-17 Thread Avi Kivity
On 04/11/2011 10:10 PM, Herve Poussineau wrote: From: Herv� Poussineau Note: your charset is UTF-8 but this is Latin-1 (I think). Please use consistent charsets. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH 1/3] slirp: Implement TFTP Blocksize option

2011-04-16 Thread Stefan Hajnoczi
On Mon, Apr 11, 2011 at 07:10:52PM +, Herve Poussineau wrote: > From: Herv? Poussineau > > This option is described in RFC 1783. As this is only an optional field, > we may ignore it in some situations and handle it in some others. > Here, if client requests a block size bigger than the block