Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 10:05:38AM +0200, Jan Kiszka wrote: > On 2014-10-02 10:03, Michael S. Tsirkin wrote: > > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > >> On 2014-09-02 17:11, Michael Roth wrote: > >>> Quoting Markus Armbruster (2014-07-30 06:19:36) > Paolo Bonzini writ

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-10-02 10:03, Michael S. Tsirkin wrote: > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: >> On 2014-09-02 17:11, Michael Roth wrote: >>> Quoting Markus Armbruster (2014-07-30 06:19:36) Paolo Bonzini writes: > Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: >>>

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Michael S. Tsirkin
On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: > On 2014-09-02 17:11, Michael Roth wrote: > > Quoting Markus Armbruster (2014-07-30 06:19:36) > >> Paolo Bonzini writes: > >> > >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-09-02 17:11, Michael Roth wrote: > Quoting Markus Armbruster (2014-07-30 06:19:36) >> Paolo Bonzini writes: >> >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > We used to be able to address both the QEMU and the

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-09-02 Thread Michael Roth
Quoting Markus Armbruster (2014-07-30 06:19:36) > Paolo Bonzini writes: > > > Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > >> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > >>> We used to be able to address both the QEMU and the KVM APIC via "apic". > >>> This doesn't work

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-07-30 Thread Markus Armbruster
Paolo Bonzini writes: > Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: >> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: >>> We used to be able to address both the QEMU and the KVM APIC via "apic". >>> This doesn't work anymore. So we need to use their parent class to turn >>> o

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-07-30 Thread Paolo Bonzini
Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > In that case, how about creating a macro with type name, > and using that? This way things don't break if we rename > something again. Don't we have warnings for that now? Paolo

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > We used to be able to address both the QEMU and the KVM APIC via "apic". > This doesn't work anymore. So we need to use their parent class to turn > off the vapic on machines that should not expose them. > > Signed-off-by: Jan Kiszka