Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
On 3/15/19 9:01 AM, Gerd Hoffmann wrote: > On Fri, Mar 15, 2019 at 08:49:06AM +0100, Martin Schrodt wrote: >> Hi, >> >> On 3/15/19 8:43 AM, Gerd Hoffmann wrote: >>> Hi, >>> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); +qapi_AudiodevPaPerDirectionOptio

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:43 AM, Gerd Hoffmann wrote: > Hi, > >> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); >> +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, >> ppdo->buffer_length); > > I'd just use > > ppdo->has_buffer_length ? ppdo->buffer_leng

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Gerd Hoffmann
On Fri, Mar 15, 2019 at 08:49:06AM +0100, Martin Schrodt wrote: > Hi, > > On 3/15/19 8:43 AM, Gerd Hoffmann wrote: > > Hi, > > > >> -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); > >> +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, > >> ppdo->buffer_l

Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored

2019-03-15 Thread Gerd Hoffmann
Hi, > -qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); > +qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, > ppdo->buffer_length); I'd just use ppdo->has_buffer_length ? ppdo->buffer_length : dev->timer_period * 4 here. cheers, Gerd