Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
On 06/05/2013 09:42 AM, Kevin Wolf wrote: Am 05.06.2013 um 15:28 hat Corey Bryant geschrieben: + +if (rwr->rc == 0) { +rwr->rc = rwr->num_sectors; +*rwr->blob_r = g_malloc(rwr->size); +memcpy(*rwr->blob_r, buf, rwr->size); Use bdrv_pread()/bdrv_pwrite() for byte-g

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Kevin Wolf
Am 05.06.2013 um 15:28 hat Corey Bryant geschrieben: > >>+ > >>+if (rwr->rc == 0) { > >>+rwr->rc = rwr->num_sectors; > >>+*rwr->blob_r = g_malloc(rwr->size); > >>+memcpy(*rwr->blob_r, buf, rwr->size); > > > >Use bdrv_pread()/bdrv_pwrite() for byte-granularity I/O instead

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
Thanks for reviewing! On 06/05/2013 05:05 AM, Stefan Hajnoczi wrote: On Tue, Jun 04, 2013 at 02:18:40PM -0400, Corey Bryant wrote: Provides TPM NVRAM implementation that enables storing of TPM NVRAM data in a persistent image file. The block driver is used to read/write the drive image. This

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 02:18:40PM -0400, Corey Bryant wrote: > Provides TPM NVRAM implementation that enables storing of TPM > NVRAM data in a persistent image file. The block driver is > used to read/write the drive image. This will enable, for > example, an ecrypted QCOW2 image to be used to s