Re: [Qemu-devel] [PATCH 1/2] linux-user: Move if-elses to a switch statement

2014-04-28 Thread Huw Davies
On Sun, Apr 27, 2014 at 02:34:09PM +0300, Riku Voipio wrote: > Hi, > It looks good in my opinion. I'll include them in my next pull request. Great, thanks! > Do you have a testcase for this, I didn't see one in ltp. No, I don't have a testcase, my use case is Wine. I can take a look at getting

Re: [Qemu-devel] [PATCH 1/2] linux-user: Move if-elses to a switch statement

2014-04-27 Thread Riku Voipio
Hi, On Fri, Apr 25, 2014 at 02:42:14PM +0100, Huw Davies wrote: > > This makes adding more message types cleaner. > > > > Signed-off-by: Huw Davies > > --- > > linux-user/syscall.c | 51 > > +-- > > 1 file changed, 33 insertions(+), 18 deletions(

Re: [Qemu-devel] [PATCH 1/2] linux-user: Move if-elses to a switch statement

2014-04-25 Thread Huw Davies
> This makes adding more message types cleaner. > > Signed-off-by: Huw Davies > --- > linux-user/syscall.c | 51 +-- > 1 file changed, 33 insertions(+), 18 deletions(-) Ping, any advice on this set? Thanks, Huw.