Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 12:50:23PM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 22/07/2013 08:49, Orit Wasserman ha scritto: > >> Older KVM versions save CS dpl value to an invalid value for real mode > >> guests > >> (0x3). This patch detect this situation when loading CPU sta

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Anthony Liguori
Paolo Bonzini writes: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: >> Older KVM versions save CS dpl value to an invalid value for real mode guests >> (0x3). This patch detect this situation when loading CPU state and set all >> the >> segments dpl to zero. >> This will allow migration from

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Eric Blake
On 07/22/2013 12:49 AM, Orit Wasserman wrote: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This patch detect this situation when loading CPU state and set all the > segments dpl to zero. > This will allow migration from older KVM on host without unrestric

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Eduardo Habkost
On Mon, Jul 22, 2013 at 12:14:25PM +0200, Paolo Bonzini wrote: > Il 22/07/2013 12:10, Orit Wasserman ha scritto: > > > As discussed offlist, I would prefer to have this in the kernel since > > > that's where the bug is. Gleb disagrees. > > > > As this is a migration bug I prefer to fix it in the

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Juan Quintela
Orit Wasserman wrote: > On 07/22/2013 01:33 PM, Andreas Färber wrote: >> Am 22.07.2013 11:49, schrieb Paolo Bonzini: >>> Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situa

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 01:33 PM, Andreas Färber wrote: > Am 22.07.2013 11:49, schrieb Paolo Bonzini: >> Il 22/07/2013 08:49, Orit Wasserman ha scritto: >>> Older KVM versions save CS dpl value to an invalid value for real mode >>> guests >>> (0x3). This patch detect this situation when loading CPU state an

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Juan Quintela
Orit Wasserman wrote: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This patch detect this situation when loading CPU state and set all the > segments dpl to zero. > This will allow migration from older KVM on host without unrestricted guest > to hosts wi

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 12:33:31PM +0200, Andreas Färber wrote: > Am 22.07.2013 11:49, schrieb Paolo Bonzini: > > Il 22/07/2013 08:49, Orit Wasserman ha scritto: > >> Older KVM versions save CS dpl value to an invalid value for real mode > >> guests > >> (0x3). This patch detect this situation whe

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Andreas Färber
Am 22.07.2013 11:49, schrieb Paolo Bonzini: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: >> Older KVM versions save CS dpl value to an invalid value for real mode guests >> (0x3). This patch detect this situation when loading CPU state and set all >> the >> segments dpl to zero. >> This will

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 12:10, Orit Wasserman ha scritto: > > As discussed offlist, I would prefer to have this in the kernel since > > that's where the bug is. Gleb disagrees. > > As this is a migration bug I prefer to fix it in the migration code only. > Fixing it in the kernel will effect all scenarios

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 12:49 PM, Paolo Bonzini wrote: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: >> Older KVM versions save CS dpl value to an invalid value for real mode guests >> (0x3). This patch detect this situation when loading CPU state and set all >> the >> segments dpl to zero. >> This will

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Gleb Natapov
On Mon, Jul 22, 2013 at 11:49:25AM +0200, Paolo Bonzini wrote: > Il 22/07/2013 08:49, Orit Wasserman ha scritto: > > Older KVM versions save CS dpl value to an invalid value for real mode > > guests > > (0x3). This patch detect this situation when loading CPU state and set all > > the > > segment

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Paolo Bonzini
Il 22/07/2013 08:49, Orit Wasserman ha scritto: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This patch detect this situation when loading CPU state and set all the > segments dpl to zero. > This will allow migration from older KVM on host without unrestr