Re: [Qemu-devel] [PATCH 09/20] cow: correctly propagate errors

2014-02-10 Thread Paolo Bonzini
Il 10/02/2014 09:04, Fam Zheng ha scritto: I'm never sure about choice of using local_err with error_propagate, or straightly pass errp, but the logic still looks right to me, so, Basically, never use error_is_set. If you do, you probably should have used instead &local_err and error_propagat

Re: [Qemu-devel] [PATCH 09/20] cow: correctly propagate errors

2014-02-10 Thread Fam Zheng
On Sun, 02/09 10:48, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/block/cow.c b/block/cow.c > index 7fc0b12..43a2150 100644 > --- a/block/cow.c > +++ b/block/cow.c > @@ -82,7 +82,7 @@